[Bug 776490] gstplayer: Add video/audio/text sink property for gstplayer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776490

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343293|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 343293:
 --> (https://bugzilla.gnome.org/review?bug=776490&attachment=343293)

Thanks, mostly looks good just one more thing

::: gst-libs/gst/player/gstplayer-video-overlay-video-renderer.c
@@ +86,3 @@
       break;
+    case VIDEO_OVERLAY_VIDEO_RENDERER_PROP_VIDEO_SINK:
+      self->video_sink = g_value_dup_object (value);

This should actually probably work like the video-sink property on playsink.
Please check the playsink code, but IIRC it does get_object() and then
ref_sink() on the object.

This also needs to be mentioned in the docs then, that this function takes the
argument as "transfer floating".

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.