[Bug 773709] player: Add get video thumbnail API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773709

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343526|none                        |needs-work
             status|                            |

--- Comment #20 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 343526:
 --> (https://bugzilla.gnome.org/review?bug=773709&attachment=343526)

Looks mostly good, just minor things now

::: gst-libs/gst/player/gstplayer.c
@@ +4267,3 @@
+ * @config: (allow-none) Additional configuration
+ *
+ * Get a sanpshot of the currently slected video stream, if any. The format
can be

Typo: sanpshot -> snapshot, slected -> selected

@@ +4272,3 @@
+ * - width, height of type G_TYPE_INT
+ * - pixel-aspect-ratio of type GST_TYPE_FRACTION
+ *   If no config is set, pixel-aspect-ratio would be 1/1 except
GST_PLAYER_THUMBNAIL_RAW_NATIVE format

except for GST_PLAYER... format in which case it is the original
pixel-aspect-ratio

@@ +4275,3 @@
+ *
+ * Returns: (transfer full):  Current video snapshot sample or %NULL on
failure
+ * Since 1.12

Needs an empty line before the Since:

@@ +4313,3 @@
+    case GST_PLAYER_THUMBNAIL_RAW_NATIVE:
+    default:
+      caps = gst_caps_new_simple ("video/x-raw", NULL, NULL);

Use gst_caps_new_empty_simple() if no fields are to be set

::: gst-libs/gst/player/gstplayer.h
@@ +213,3 @@
+  GST_PLAYER_THUMBNAIL_JPG,
+  GST_PLAYER_THUMBNAIL_PNG
+} GstPlayerThumbnailType;

GstPlayerThumbnailFormat maybe instead?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.