[Bug 776720] souphttpsrc: no request retry on early server termination

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jan 16 20:24:45 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=776720

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342728|none                        |needs-work
             status|                            |

--- Comment #6 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 342728:
 --> (https://bugzilla.gnome.org/review?bug=776720&attachment=342728)

::: ext/soup/gstsouphttpsrc.c
@@ -1667,3 @@
   } else {
     gst_buffer_unref (*outbuf);
-    if (read_bytes < 0) {

We should preserve this condition, because it is an explicit error. It can also
happen when you don't have the size and then we have to retry anyway.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list