[Bug 777222] souphttpsrc: redirect uri is never set

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jan 16 21:52:00 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=777222

--- Comment #6 from Arnaud Vrac <rawoul at gmail.com> ---
(In reply to Thiago Sousa Santos from comment #5)
> Review of attachment 343543 [details] [review]:
> 
> ::: ext/soup/gstsouphttpsrc.c
> @@ +1444,3 @@
>      return GST_FLOW_FLUSHING;
>  
> +  src->ret = GST_FLOW_OK;
> 
> Is this part needed if you already reset it to GST_FLOW_OK when it is a
> CUSTOM_ERROR?

Yes, otherwise the redirection is retried until max_retries and then fails.
That's why I implemented the second patch, the src->ret variable is confusing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list