[Bug 777376] matrixmix: New element that mixes audio channels

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777376

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343669|none                        |needs-work
             status|                            |

--- Comment #13 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 343669:
 --> (https://bugzilla.gnome.org/review?bug=777376&attachment=343669)

Can you set the matrix using gst-launch? If yes, can you add an example of that
in the doc blurb at the top? If not, it would be nice to add a short C blurb
showing how to create one. It's not evident to me how to do this, so it would
be really hard for someone who is a GLib/GStreamer expert!

Any reason to force the identity matrix if first-channels=1 ? Couldnt it also
work with a subset of a user-set matrix ? (or a superset extended by the
identity matrix?)

This also looks like something where ORC could be used if someone wants to have
fun ;)

::: gst/audiomixmatrix/gstaudiomixmatrix.c
@@ +549,3 @@
+     * hang. */
+    GST_ERROR_OBJECT (self, "Invalid settings detected in manual mode. "
+        "Please specify in-channels, out-channels and matrix.");

Shouldn't you also put an error message here using GST_ELEMENT_ERROR() ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.