[Bug 777409] pluginbase: Query for OpenGL app_context

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777409

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343678|none                        |needs-work
             status|                            |

--- Comment #2 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 343678:
 --> (https://bugzilla.gnome.org/review?bug=777409&attachment=343678)

A couple of things need work on.

::: gst/vaapi/gstvaapipluginbase.c
@@ +77,3 @@
     plugin_set_display (plugin, display);
+
+  gst_gl_handle_set_context (element, context, (GstGLDisplay
**)&plugin->gl_display, (GstGLContext **)&plugin->gl_other_context);

Doesn't this need #if USE_GST_GL_HELPERS around it?

@@ +229,3 @@
+    if (plugin->gl_display) {
+      GError *error = NULL;
+      gst_gl_display_create_context ((GstGLDisplay *)plugin->gl_display,
(GstGLContext *)plugin->gl_other_context, (GstGLContext **)&gl_context,
&error);

This will race with any other element attempting to create an OpenGL context.

You should follow the same pattern as the other OpenGL elements here:
https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglbasefilter.c#n330

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.