[Bug 766177] qtdemux: Critical errors reported playing mp4 file with only xmp tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766177

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.11.2

--- Comment #15 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
commit 642331fd7f5b6236049fbd3b56f2f7f8a71ba174
Author: David Warman <dwarman at manglebit.org>
Date:   Fri Jan 13 12:27:40 2017 +0000

    qtdemux: avoid XMP tag parsing fatal error.

    qtdemux_handle_xmp_taglist() requires a writable taglist,
    but qtdemux->tag_list can become non-writable, specifically
    after sending global tags (qtdemux.c:958), which adds a
    second reference.  Ensure the list is made writable before
    calling (make_writable will copy the list if necessary).

    https://bugzilla.gnome.org/show_bug.cgi?id=766177

commit 5bb7ca8a623426cde67a6cf54526bcc6a3fd3395
Author: Thiago Santos <thiagossantos at gmail.com>
Date:   Tue May 31 13:17:45 2016 -0300

    qtdemux: rework taglist handling

    Keep taglist around during element existance to avoid having to
    create it at different places before usage. Makes code simpler to handle.

    https://bugzilla.gnome.org/show_bug.cgi?id=766177

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.