[Bug 777409] pluginbase: Query for OpenGL app_context

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777409

Matt Fischer <mattfischer84 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343678|needs-work                  |none
             status|                            |
 Attachment #343678|0                           |1
        is obsolete|                            |

--- Comment #4 from Matt Fischer <mattfischer84 at gmail.com> ---
Created attachment 343734
  --> https://bugzilla.gnome.org/attachment.cgi?id=343734&action=edit
pluginbase: Query for OpenGL app_context

Thanks for your feedback.  I've updated the patch to do the display thread loop
as you mentioned, and it seems to work.

Victor, all right, I'll see if I can convince you. :)  This patch actually
doesn't create a GstGLDisplay by itself, it can only query for one which has
been set by the rest of the pipeline.  The only thing that this change would
allow is for the plugin to construct its own GstGLContext based on the display
and possibly other_context that it found by querying the pipeline.

So yes, we may construct a new context object, whereas before we could only
query for one from somebody else.  But we would always do it based on a display
and other_context that was provided from outside.  Does that sound permissible,
or would you rather not create any OpenGL objects at all?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.