[Bug 776927] vaapi: plugins: accept GLMemory buffers from upstream

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776927

Matt Fischer <mattfischer84 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343387|needs-work                  |none
             status|                            |
 Attachment #343387|0                           |1
        is obsolete|                            |

--- Comment #15 from Matt Fischer <mattfischer84 at gmail.com> ---
Created attachment 343748
  --> https://bugzilla.gnome.org/attachment.cgi?id=343748&action=edit
Patch to add dmabuf export to gldownload

Using gst_mini_object_set_qdata() seems to work great.  I've uploaded a new
version which uses it to save the images it exports, so now it's a bit less
offensive.

I still don't really know what to say about the mappable vs. non-mappable
issue.  Detecting it during playback and renegotiating caps seems kind of
tricky.  I'm not an expert on dmabufs, so I really don't know how to predict
whether in practice these exported images would always be mappable, or not.  So
it's hard to know whether we're safe doing this all the time, or whether that
will cause problems in some circumstances.

I know some other elements like v4lsrc have a property which can be set on
them, which directs them to attempt a dmabuf export.  That's a little bit
clunky, but it would be one option to ensure that we don't accidentally do this
in settings where it wouldn't work properly.  Would that be a good option to
pursue, or do you have some other thoughts on how this could best be
integrated?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.