[Bug 777458] decklinkaudiosrc: Option to use max channels supported by device

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777458

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343733|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 343733:
 --> (https://bugzilla.gnome.org/review?bug=777458&attachment=343733)

::: sys/decklink/gstdecklinkaudiosrc.cpp
@@ +742,3 @@
+    if (self->input->attributes) {
+      HRESULT ret = self->input->attributes->GetInt
+          (BMDDeckLinkMaximumAudioChannels, &self->channels_found);

I would move that to gstdecklink.cpp in the loop where we detect all the cards,
and then just reuse that value here

@@ +758,3 @@
+        self->channels_found = DEFAULT_CHANNELS;
+      }
+    }

You might also want to negotiate here the maximum of the channels supported by
the card and downstream, i.e. always return the whole range here and in
fixate_caps() fixate to the maximum

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.