[Bug 775490] vaapi: encode: jpeg should release configuration after each frame (multi file support)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775490

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343828|none                        |needs-work
             status|                            |

--- Comment #17 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 343828:
 --> (https://bugzilla.gnome.org/review?bug=775490&attachment=343828)

Thanks. It is better to keep atomic commits, isolating the changes as much as
possible.

::: gst/vaapi/gstvaapidecode.c
@@ +218,2 @@
 #if (USE_GLX || USE_EGL)
+  if (gst_vaapi_display_has_opengl (GST_VAAPI_PLUGIN_BASE_DISPLAY (decode))) {

Good catch! could you split this in a different patch?

@@ +225,3 @@
     return FALSE;
   }
+#endif

This should be above, where it was before. It purpose is for possible memory
exhaustion.

::: gst/vaapi/gstvaapipostproc.c
@@ +1068,3 @@
+  if (!gst_vaapi_display_has_opengl (GST_VAAPI_PLUGIN_BASE_DISPLAY (postproc))
+      && gl_upload_meta_idx > -1) {
+    gst_caps_remove_structure (caps, gl_upload_meta_idx);

Add this in the same patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.