[Bug 740803] waylandsink: Double-check the frame callback before dropping frames

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=740803

--- Comment #5 from Praveen R Jadhav <praveen.j at samsung.com> ---
> This is no longer an atomic op, it's protected by the render_lock now. That
> basically means, you'll get a deadlock. You need to drop the render lock
> before calling wl_display_roundtrip_queue().
It is better to check using g_cond_wait_until()/g_cond_signal() APIs and
completely avoid wl_display_roundtrip_queue() IMO. wl_display_roundtrip() is a
blocking call which is not returned until frame_redraw_cb() and
buffer_release() callbacks are not completed. Whereas g_cond may be signalled
as soon as frame_redraw_cb() is received.
Conditional timeout of one frame duration (fps_d/fps_n) is reasonable which can
be finalized after testing further.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.