[Bug 777409] pluginbase: Query for OpenGL app_context

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777409

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343736|reviewed                    |needs-work
             status|                            |

--- Comment #7 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 343736:
 --> (https://bugzilla.gnome.org/review?bug=777409&attachment=343736)

::: gst/vaapi/gstvaapipluginbase.c
@@ +253,3 @@
+      } while (!gst_gl_display_add_context (gl_display, (GstGLContext
*)gl_context));
+      GST_OBJECT_UNLOCK (gl_display);
+    }

I would move all this block to a new function.

::: gst/vaapi/gstvaapivideocontext.c
@@ +82,3 @@
+    structure = gst_context_get_structure (context);
+    ret = gst_structure_get (structure, GST_VAAPI_DISPLAY_CONTEXT_TYPE_NAME,
+        GST_VAAPI_TYPE_DISPLAY, display_ptr, NULL);

I guess you are working in branch 1.10 because this doesn't compile in master,
since GST_VAAPI_TYPE_DISPLAY doesn't exist, it is GST_TYPE_VAAPI_DISPLAY.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.