[Bug 777409] pluginbase: Query for OpenGL app_context

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777409

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343911|none                        |reviewed
             status|                            |

--- Comment #13 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 343911:
 --> (https://bugzilla.gnome.org/review?bug=777409&attachment=343911)

It looks good in general. Just a couple nitpicks.

What I'm worried now, is what will happen in non OpenGL environment? for
example headless environment, or embedded (using kmssink, for example), or in
Wayland (we have currently a couple problems there)

::: gst/vaapi/gstvaapipluginbase.c
@@ +235,3 @@
+
+  GstGLDisplay *gl_display = (GstGLDisplay *) plugin->gl_display;
+  GstGLContext *gl_other_context = (GstGLContext *) plugin->gl_other_context;

these two lines will raise a warning in ISO C90 compilers.

@@ +236,3 @@
+  GstGLDisplay *gl_display = (GstGLDisplay *) plugin->gl_display;
+  GstGLContext *gl_other_context = (GstGLContext *) plugin->gl_other_context;
+  if (gl_display) {

the idiomatic style in gstreamer-vaapi has been -normally- early returns. I
guess here applies.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.