[Bug 776720] souphttpsrc: no request retry on early server termination

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776720

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343791|none                        |reviewed
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 343791:
 --> (https://bugzilla.gnome.org/review?bug=776720&attachment=343791)

::: ext/soup/gstsouphttpsrc.c
@@ +1632,3 @@
     gst_buffer_unref (*outbuf);
+    if (read_bytes < 0 ||
+        (src->have_size && src->read_position < src->content_size)) {

This seems problematic as Content-Size is the "encoded" content-size while read
position is "decoded". Think of the case of gzip/deflate compression. libsoup
is decompressing things for us transparently but the content-size will be a
different value.

I'm worried that we might run into an infinite loop here, retrying over and
over again just because we can read fewer bytes than content-size says there
are (for whatever reason).


Is something preventing that?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.