[Bug 777409] pluginbase: Query for OpenGL app_context

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777409

--- Comment #16 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Matt Fischer from comment #15)
> Created attachment 344069 [details] [review]
> pluginbase: Query for OpenGL app_context

Matt, just note that it still leads to compilation failure because of this line
:) ( there is no "element" )

+#if USE_GST_GL_HELPERS
+  gst_gl_handle_set_context (element, context, (GstGLDisplay
**)&plugin->gl_display, (GstGLContext **)&plugin->gl_other_context);


Anyway, I like the purpose of this patch. In addition, it fixes very old issue
for vaapi/egl. Thanks Matt!

But we should think about cases which don't need opengl stuff.
For example, with this patch, it's not running with vaapisink.(on X/Wayland)
Probably it's related to GLDisplay(X/Wayland), which is created already.

With kmssink(on non X/Wayland), it fails to create gl context, and fails to
play.

With x(v)imagesink/waylandsink, it looks playing fine, but it also creates
GLDisplay/GLContext which is not necessary.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.