[Bug 770678] qtdemux: Not considering sample size when calculating size of chunk.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770678

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344280|none                        |reviewed
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 344280:
 --> (https://bugzilla.gnome.org/review?bug=770678&attachment=344280)

::: gst/isomp4/qtdemux.c
@@ +8299,3 @@
           cur->size =
               (stream->samples_per_chunk * stream->n_channels) /
+              stream->samples_per_frame * stream->bytes_per_frame *
stream->sample_size;

This looks correct (but might need some care to prevent overflows?)

@@ +8314,3 @@
         cur++;

+        stream->stco_sample_index += stream->samples_per_chunk *
stream->sample_size;

But this seems not obviously correct at least. Why would the sample_index take
the sample_size into account? Shouldn't that just take the number of samples?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.