[Bug 776601] rtspsrc: set absolute range headers if only UTC is accepted

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776601

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344260|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 344260:
 --> (https://bugzilla.gnome.org/review?bug=776601&attachment=344260)

::: gst/rtsp/gstrtspsrc.c
@@ +6264,3 @@
+                                   &respranges, 0);
+      src->need_utc_range = FALSE;
+      if (g_ascii_strcasecmp(respranges, "UTC") == 0) {

Might be NULL, right?

@@ +7192,3 @@
   gchar val_str[G_ASCII_DTOSTR_BUF_SIZE] = { 0, };

+  if (src->range && src->need_utc_range && src->range->min.type ==
GST_RTSP_TIME_UTC && src->range->max.type == GST_RTSP_TIME_UTC) {

Who/how would the range ever be filled with an UTC range?

@@ +7193,3 @@

+  if (src->range && src->need_utc_range && src->range->min.type ==
GST_RTSP_TIME_UTC && src->range->max.type == GST_RTSP_TIME_UTC) {
+    // seconds = ((hours * 60) + mins) * 60 + secs;

No C99/C++ comments

@@ +7204,3 @@
+    return
g_strdup_printf("clock=%4d%02d%02dT%02d%02d%02dZ-%4d%02d%02dT%02d%02d%02dZ",
+                            src->range->min2.year, src->range->min2.month,
src->range->min2.day, hours1, mins1, secs1,
+                            src->range->max2.year, src->range->max2.month,
src->range->max2.day, hours2, mins2, secs2);

Run gst-indent over the code

@@ +7209,1 @@
   if (src->range && src->range->min.type == GST_RTSP_TIME_NOW) {

This should probably become "if (...) { } else if (...) { }" etc, simplified a
bit

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.