[Bug 777682] hls: m3u8: Set sequence position for live

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777682

--- Comment #14 from Seungha Yang <sh.yang at lge.com> ---
(In reply to Sebastian Dröge (slomo) from comment #10)
> Review of attachment 344195 [details] [review]:
> 
> ::: ext/hls/m3u8.c
> @@ +760,3 @@
>  
> +      sequence_pos =
> +          self->last_file_end - GST_M3U8_MEDIA_FILE (file->data)->duration;
> 
> Why would that never be negative?

It doesn't make sense that it is negative at that moment, but for safe,
I added one more condition :)

> 
> @@ +771,2 @@
>          file = file->prev;
> +        sequence_pos -= GST_M3U8_MEDIA_FILE (file->data)->duration;
> 
> And this?

Since for loop is checking the file duration, it never be negative
At line 768

for (i = 0; i < GST_M3U8_LIVE_MIN_FRAGMENT_DISTANCE && file->prev &&
     GST_M3U8_MEDIA_FILE (file->prev->data)->duration <= sequence_pos;
     ++i) {
....


Please apply "hls: m3u8: Set sequence position for live" on top of 
"hls: Exclusion of last three fragment in case of live playback"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.