[Bug 777841] waylandsink: fix buffer size when copying to pool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777841

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344429|none                        |needs-work
             status|                            |

--- Comment #1 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 344429:
 --> (https://bugzilla.gnome.org/review?bug=777841&attachment=344429)

I think this is correct, just move out the assignment out of the loop please.

::: ext/wayland/gstwaylandsink.c
@@ +649,3 @@
       sink->video_info.offset[i] = vmeta->offset[i];
       sink->video_info.stride[i] = vmeta->stride[i];
+      sink->video_info.size = mem->size;

Written this way, it looks wrong, as you endup overriding over and over with
the same value. I think for anything shm we already ensure there is only 1 mem,
so the code is right, I would just pull that out of the loop.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.