[Bug 777409] pluginbase: Query for OpenGL app_context

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jan 27 17:46:58 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=777409

--- Comment #32 from Matt Fischer <mattfischer84 at gmail.com> ---
Review of attachment 344411:
 --> (https://bugzilla.gnome.org/review?bug=777409&attachment=344411)

::: gst/vaapi/gstvaapipluginutil.c
@@ +252,3 @@
+   * GstVaapiDisplay. Let's them to choose their own
+   * GstVaapiDisplay */
+  GstVaapiPluginBase *const plugin = GST_VAAPI_PLUGIN_BASE (element);

Maybe it would be a bit cleaner to handle this by making a vfunc that the
postproc and decoder classes implement, rather than downcasting the element in
here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list