[Bug 776413] flacenc: Wrong quality levels in GStreamer, level 9 doesn't exist in libflac

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776413

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Christian Stadelmann from comment #9)
> (In reply to Sebastian Dröge (slomo) from comment #7)
> > But didn't you say that there's also a mismatch between settings for our
> > other quality levels?
> 
> Yes, I did. Most notably, the FLAC__stream_encoder_set_compression_level
> does NOT set the blocksize any more, but sets apodization.
> Is it Ok if I
> 1. introduce a new PROP_APODIZATION value to the enum and a new apodization
> parameter?
> 2. and reorder enum entries?

Reorder which enum entries?

> 3. change GstFlacEncParams: remove blocksize, add apodization, reorder fields
> 4. change gst_flac_enc_update_quality to use
> FLAC__stream_encoder_set_compression_level instead of relying on the
> flacenc_params array and get rid of flacenc_params array, leaving only
> default values of each parameter.

Sounds like a plan

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.