[Bug 776413] flacenc: Wrong quality levels in GStreamer, level 9 doesn't exist in libflac

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776413

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Christian Stadelmann from comment #12)
> Is there any simple way to test my code? I am used to gst-launch-1.0, but
> how do I get it to use the newly compiled flac library?

You mean the new libgstflac.so? Either overwrite the existing one from your
system, use something like gst-uninstalled or just set GST_PLUGIN_PATH to the
location of the new .so. It should override the system path then.

> Why do you `#define` constants instead of making them `const`? Would you
> mind if I changed this to using `const`?

Convention

> (In reply to Sebastian Dröge (slomo) from comment #11)
> > (In reply to Christian Stadelmann from comment #9)
> > > Is it Ok if I
> > > 1. introduce a new PROP_APODIZATION value to the enum and a new apodization
> > > parameter?
> > > 2. and reorder enum entries?
> > 
> > Reorder which enum entries?
> 
> The ones in the anonymous enum starting around line 106.

You mean the PROP_* ones? Why would you like to reorder them? I think it's ok
to do so, but doesn't seem very useful other than making the diff bigger and
increasing the risk of merge conflicts :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.