[Bug 776491] multiqueue: Update buffering level based on the lowest value

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776491

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bilboed at bilboed.com

--- Comment #6 from Edward Hervey <bilboed at bilboed.com> ---
(In reply to Seungha Yang from comment #1)
> Created attachment 342471 [details] [review]
> multiqueue: Calculate buffering of each queue only when it is updated
> 
> Store each buffering level of singlequeue in itself

Looks good

(In reply to HoonHee Lee from comment #4)
> Created attachment 344623 [details] [review]
> multiqueue: Adjust buffering level to MAX if SQ's srcpad is not linked
>  
> When I changed track so quickly and repeatedly, buffering message is not
> posted as well.
>  
> After track is changed, new activated slot still on GST_FLOW_NOT_LINKED
> status.

  This shouldn't happen. When a pad is relinked it should get a
GST_EVENT_RECONFIGURE, which switches srcresult to GST_FLOW_OK.

> Because, old pushed buffer is returned lately to the activated slot's output
> and non activated slot still be accepted as activated slot.
>  
> So, it is better to use gst_pad_is_linked () instead of GST_FLOW_NOT_LINKED.
>  
  gst_pad_is_linked() should be avoided because it's expensive and it doesn't
give you a full downstream visibility (there might be a change in an
element/pad further downstream).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.