[Bug 776928] hlsdemux: Set fragment header uri if exists

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776928

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344380|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 344380:
 --> (https://bugzilla.gnome.org/review?bug=776928&attachment=344380)

::: ext/hls/m3u8.c
@@ +715,3 @@
+          last_init_file = file;
+
+          self->init_files = g_list_append (self->init_files, file);

Either prepend() and reverse() in the end, or use a GQueue. Repeated
g_list_append() is quadratic

::: ext/hls/m3u8.h
@@ +102,3 @@
+
+  GstM3U8MediaFile *init_file;  /* Media Initialization corresponding to
+                                 * current segment, if exist (doesn't hold
ref) */

This seems unfortunate as you have to keep both pointers in sync from two
different lists now. It would be better to store a new struct inside the list
of files that contains both.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.