[Bug 776997] hlsdemux: Implement adaptivedemux's _stream_seek()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776997

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343107|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 343107:
 --> (https://bugzilla.gnome.org/review?bug=776997&attachment=343107)

Can you split that up into multiple patches? This looks like several changes
(3?) at once, including

::: ext/hls/gsthlsdemux.c
@@ +362,3 @@
+      (flags & GST_SEEK_FLAG_SNAP_NEAREST) == GST_SEEK_FLAG_SNAP_NEAREST;
+  snap_before = ! !(flags & GST_SEEK_FLAG_SNAP_BEFORE);
+  snap_after = ! !(flags & GST_SEEK_FLAG_SNAP_AFTER);

Refactoring the seek() function generally, mostly be moving code around a bit

@@ +366,3 @@
+  if (target_type == GST_SEEK_TYPE_NONE && !(flags & GST_SEEK_FLAG_FLUSH)) {
+    /* No need to move */
+    gst_segment_do_seek (&demux->segment, rate, format, flags, start_type,

Doing nothing if not needed here

@@ +379,3 @@
+    /* FIXME: check and handle return */
+    gst_hls_demux_stream_seek (stream, rate > 0, flags, target_pos,
+        &current_pos);

Moving part of the seek handling into the new function

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.