[Bug 775615] decodebin3: Select default track by GstStreamFlags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775615

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344092|none                        |needs-work
             status|                            |

--- Comment #5 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 344092:
 --> (https://bugzilla.gnome.org/review?bug=775615&attachment=344092)

::: gst/playback/gstdecodebin3.c
@@ +409,3 @@
   } G_STMT_END

+#define DUMP_SELECTION_LIST(list, name) G_STMT_START {    \

While this is quite useful (and should/could be used in more places), can you
put this in a separate commit ?

* protect it with "#ifndef GST_DISABLE_GST_DEBUG" so we don't iterate the list
if no debugging is enabled
* Pass an object as an argument and use the _OBJECT debugging variant
* Use a lower debugging category

@@ +1103,3 @@
+          gst_stream_type_get_name (curtype));
+      sorted = g_list_prepend (sorted, stream);
+      for (j = 0; j < g_list_length (reused_streams); j++) {

See comment about iterating lists in the other patch review.

@@ +1125,3 @@
+
+  /* 5. If not, match one stream of each type */
+  for (i = 0; i < g_list_length (sorted); i++) {

See comment about iterating lists in the other patch review.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.