[Bug 784414] ges-timeline-element: emit 'deep-notify' signal in main thread

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Jul 1 11:29:32 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=784414

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354758|none                        |needs-work
             status|                            |

--- Comment #6 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 354758:
 --> (https://bugzilla.gnome.org/review?bug=784414&attachment=354758)

Apart from that, looks good.

::: ges/ges-timeline-element.c
@@ +1305,3 @@
+
+  data->child = gst_object_ref (child);
+    return;

Does that work?! It should be g_param_spec_ref/g_param_spec_unref as GParamSpec
is not a GObject

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list