[Bug 784254] rtp: vrawdepay: add support for 8-bit monochrome along with UK DEF STAN 00-82 compliant scan lines

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784254

--- Comment #7 from Craig McLaren <craig.mclaren at uk.thalesgroup.com> ---
The line offset patch doesn't fix the issue as the packets being received do
not believe they have an offset. The line number itself starts at 1 as opposed
to 0. using warning messages I have output this to the command line.

0:00:03.925780801 23177       0x7f9540 WARN            rtpvrawdepay
gstrtpvrawdepay.c:398:gst_rtp_vraw_depay_process_packet:<rtpvrawdepay0> offset
value 0
0:00:03.925787860 23177       0x7f9540 WARN            rtpvrawdepay
gstrtpvrawdepay.c:524:gst_rtp_vraw_depay_process_packet:<rtpvrawdepay0>
skipping line 768: out of range
0:00:03.927379987 23177       0x7f9540 WARN            rtpvrawdepay
gstrtpvrawdepay.c:398:gst_rtp_vraw_depay_process_packet:<rtpvrawdepay0> offset
value 0
0:00:03.927417099 23177       0x7f9540 WARN            rtpvrawdepay
gstrtpvrawdepay.c:502:gst_rtp_vraw_depay_process_packet:<rtpvrawdepay0> line
number 1
0:00:03.927442795 23177       0x7f9540 WARN            rtpvrawdepay
gstrtpvrawdepay.c:398:gst_rtp_vraw_depay_process_packet:<rtpvrawdepay0> offset
value 0
0:00:03.927454233 23177       0x7f9540 WARN            rtpvrawdepay
gstrtpvrawdepay.c:502:gst_rtp_vraw_depay_process_packet:<rtpvrawdepay0> line
number 1
0:00:03.927475784 23177       0x7f9540 WARN            rtpvrawdepay
gstrtpvrawdepay.c:398:gst_rtp_vraw_depay_process_packet:<rtpvrawdepay0> offset
value 0


using 

if (line < 2)
      GST_WARNING_OBJECT (depayload, "line number %u", line);

and 

scan_line_offset = rtpvrawdepay->line_offset;
  GST_WARNING_OBJECT (depayload, "offset value %u", scan_line_offset);

I think the best way to fix this is to check what line number the payload
starts and go from there though I'm not sure how you feel about this as only
BT656 video would have this issue.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.