[Bug 723868] adaptivedemux: Handle users _eos event

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jul 3 19:50:38 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=723868

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354854|none                        |needs-work
             status|                            |

--- Comment #11 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 354854:
 --> (https://bugzilla.gnome.org/review?bug=723868&attachment=354854)

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +610,3 @@
+
+    GST_MANIFEST_LOCK (demux);
+    gst_adaptive_demux_reset (demux);

This function sends EOS on all pads already, so the later chaining to bin
default implementation is redundant. Though, the EOS has the wrong segnum. This
also means that calling reset need to be queued somehow.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list