[Bug 783754] splitmuxsink: Added new async-finalize mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783754

--- Comment #10 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 354845:
 --> (https://bugzilla.gnome.org/review?bug=783754&attachment=354845)

It would be good to add some more text to the element blurb at the top talking
about async-finalize mode, and how to use the factory and properties
properties.

::: gst/multifile/gstsplitmuxsink.c
@@ +1485,3 @@
+                NULL);
+            gst_element_call_async (sink, _lock_and_set_to_null, splitmux,
+                NULL);

I don't think these calls should be async. At this point the muxer and sink
should already be EOS, so it shouldn't take long to reach NULL synchronously.
Otherwise, there's no guarantee the elements still exist by the time the
callback happens since there's no ref held.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.