[Bug 784494] glupload: Put directviv upload high priority than dma upload

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784494

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #6 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Haihua Hu from comment #5)
> All imx platform share the same code and the recent imx8 platform has
> implement VPU to do video decode and support physical memory buffer but it
> also has ion dmabuf allocator. Then it will go through dmabuf upload. This
> is not right. Actually we need check if the buffer is physical memory buffer
> first and then dmabuf.

This of course is not normally something userspace shall be aware of, this is
special hack form Freescale/NXP/Qualcomm (not sure which name you use now ;-P).

Though, if your decoder produces DMABuf allocated using the CMA, you should not
need your "physical memory" hack anymore. The reason the current uploader is
slower is most likely because it's doing the color conversion on the GPU (R8 +
RG88 + shaders), which I believe is still pretty slow even on newer IMX.

For Etnaviv, which does not implement your "physical memory" hack, they started
adding a direct upload to glupload. In Etnaviv, the VPU is used instead for
conversion. The result has been reported has good as the other method, with the
benifit it's standard and can be used on other boards. Patches are over there:

  https://bugzilla.gnome.org/show_bug.cgi?id=783521

Meanwhile, I'm just encouraging you to move forward something slightly more
standard, I don't see any problem of moving this uploader higher in the stack,
after all this is only used on your platform, actually it's only used with your
SW stack.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.