[Bug 773218] rtpbin: pipeline gets an EOS when any rtpsources byes

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jul 5 01:24:32 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=773218

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
                 CC|                            |olivier.crete at ocrete.ca
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.13.1

--- Comment #29 from Olivier Crête <olivier.crete at ocrete.ca> ---
We stumbled onto this indepdendantly, here is a series of two patches that
fixes this, including a unit test.

The problem with the RTSP sink was that the EOS was not sent when it should
have been in that case with the other patch.


commit 7e7e52caa0c0d8e64735c1939bfc070a1148c942
Author: Olivier Crête <olivier.crete at collabora.com>
Date:   Tue Jul 4 12:24:41 2017 -0400

    rtpsession: Only send EOS if all sources have been marked bye

    Now that multiple sender RTPSource can share the same RTPSession, we
    must not send an EOS unless they're all marked bye.

commit 96e71b02867319dd11efd838394e4a8ab459d6c2
Author: Olivier Crête <olivier.crete at collabora.com>
Date:   Tue Jul 4 17:42:25 2017 -0400

    rtpsession: Send EOS if all internal sources sent bye

    The ones which are not internal should not matter, and we should
    wait for all sources to have sent their BYEs.

    And add unit test

    https://bugzilla.gnome.org/show_bug.cgi?id=773218

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list