[Bug 784552] dvdlpcmdec: Added support for Blu-Ray audio

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784552

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354935|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 354935:
 --> (https://bugzilla.gnome.org/review?bug=784552&attachment=354935)

::: gst/dvdlpcmdec/gstdvdlpcmdec.c
@@ +348,3 @@

+  gst_dvdlpcmdec_update_audio_formats (dvdlpcmdec, channels, rate, format,
+      channels, channel_positions);

channels-1

@@ +420,3 @@
   channels = ((header >> 8) & 0x7) + 1;

+  gst_dvdlpcmdec_update_audio_formats (dec, channels, rate, format, channels,

channels-1

@@ +610,3 @@
+      case 0x2:
+        format = GST_AUDIO_FORMAT_S32BE;
+        dvdlpcmdec->width = 20;

This is either also GST_AUDIO_FORMAT_S24BE or GST_AUDIO_FORMAT_S20BE. The code
in ffmpeg suggests it's the former though

@@ +614,3 @@
+      case 0x3:
+        format = GST_AUDIO_FORMAT_S32BE;
+        dvdlpcmdec->width = 24;

GST_AUDIO_FORMAT_S24BE AFAIU?

@@ +671,3 @@
+        break;
+    }
+    GST_DEBUG_OBJECT (dvdlpcmdec, "got channels %i rate %i format %s\n",

Usually we use %d for integers (decimal, vs %x for hexadecimal). And the \n
should go away

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.