[Bug 783625] typefinding: add support for jpc
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Jul 6 06:52:26 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=783625
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #354401|none |needs-work
status| |
--- Comment #43 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 354401:
--> (https://bugzilla.gnome.org/review?bug=783625&attachment=354401)
::: gst/typefind/gsttypefindfunctions.c
@@ +3206,3 @@
+ /* SOC marker + SIZ marker */
+ if ((data = gst_type_find_peek (tf, 0, 4)) != NULL) {
+ if (memcmp (data, "\xFF\x4F\xFF\x51", 4) != 0)
Nicer to put this into a const guint8 marker[] = {0xff, 0x4f, 0xff, 0x51};
@@ +3213,3 @@
+ }
+
+ while (!found_sot) {
This should probably not search until the end of file, but stop after 1KB or so
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list