[Bug 783291] jpeg2000parse: parse frame when caps are null

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783291

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354393|none                        |needs-work
             status|                            |

--- Comment #27 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 354393:
 --> (https://bugzilla.gnome.org/review?bug=783291&attachment=354393)

::: gst/videoparsers/gstjpeg2000parse.c
@@ +516,3 @@
+    colorspace =
+        (numcomps >=
+        3) ? GST_JPEG2000_COLORSPACE_RGB : GST_JPEG2000_COLORSPACE_GRAY;

Why RGB and not YUV? :) This seems like it should print a warning at least. For
all guesses that we make which are not necessarily correct.

@@ +670,3 @@
+    if (current_caps_struct) {
+      if (gst_structure_get_fraction (current_caps_struct, "framerate",
&fr_num,
+              &fr_denom)) {

Merge these two ifs into one

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.