[Bug 784599] kmssink: support videooverlay interface

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784599

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354995|none                        |reviewed
             status|                            |

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 354995:
 --> (https://bugzilla.gnome.org/review?bug=784599&attachment=354995)

::: sys/kms/gstkmssink.c
@@ +724,3 @@
+        "height", G_TYPE_INT, self->preferred_height, NULL);
+  }
+  GST_DEBUG_OBJECT (self, "allowed caps %"GST_PTR_FORMAT, caps);

I don't think overriding the width/height is correct here. Instead, you should
prepand you preferred caps, and keep the other valid caps. And you should do
that always.

@@ +732,3 @@
     out_caps = caps;
   }
+  g_mutex_unlock (&self->glock);

You seem to be holding the lock a bit too long, just a nitpick.

@@ +873,3 @@

+  if (self->reconfigure) {
+    self->reconfigure = FALSE;

Need the glock ?

@@ +1515,3 @@
   sink->plane_id = -1;
+  sink->reconfigure = FALSE;
+  g_mutex_init (&sink->glock);

Are you sure the GST_OBJECT_LOCK() could not have made the job here ? It's only
used for math, it never does any calls around.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.