[Bug 784735] New: gst-libav: Memory leak and possible crash in avio_alloc_context.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784735

            Bug ID: 784735
           Summary: gst-libav: Memory leak and possible crash in
                    avio_alloc_context.
    Classification: Platform
           Product: GStreamer
           Version: 1.12.1
                OS: All
            Status: NEW
          Severity: critical
          Priority: Normal
         Component: gst-libav
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: sp.gupta at samsung.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Memory leak and possible crash in avio_alloc_context.  

gst-libav-1.12.1/ext/libav/gstavprotocol.c

In function gst_ffmpegdata_open at line: 265 
avio_alloc_context : There is no NULL check while deferring so I think if this
function fails i.e return NULL then it should be possible crash and Memory leak
of allocated buffer.

Solution: NULL check should be applied before derefer and in case of failure
buffer should be freed.

As per API documentation :: Allocated AVIOContext or NULL on failure.

This is for reference
https://www.ffmpeg.org/doxygen/2.5/avio_8h.html#a853f5149136a27ffba3207d8520172a5

like above it should be also in function  "gst_ffmpegdata_open" .

Also there  should be NULL check for handle h in "gst_ffmpegdata_close" and
same also "gst_ffmpeg_pipe_close"

Please consider it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.