[Bug 783588] vaapidecoder: Add framework for codec-specific properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783588

--- Comment #25 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Matt Staples from comment #24)
> Review of attachment 355111 [details] [review]:
> 
> ::: gst/vaapi/gstvaapidecode_props.c
> @@ +41,3 @@
> +  switch (prop_id) {
> +    case GST_VAAPI_DECODER_H264_PROP_FORCE_LOW_LATENCY:
> +      g_value_set_boolean (value, priv->is_low_latency);
> 
> Although it's not necessary for the low-latency property, this doesn't
> currently handle dynamic changes to the property value once the h264 decoder
> object has been constructed.  For future properties that might need it, is
> there a way to extend this to handle dynamic updates to an already-existing
> decoder object?

Yes, you have access to the object, and the object contains the decoder, you
just need the proper casts and validate if it is already created

like in the previous patch:

GstVaapiDecoderH264 *decoder =
      GST_VAAPI_DECODER_H264 (GST_VAAPIDECODE (object)->decoder);
if (decoder)
  gst_vaapi_decoder_h264_set_property (decoder, val);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.