[Bug 783114] omxh264dec: pass profile and level info to decoder

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783114

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355248|none                        |reviewed
             status|                            |

--- Comment #23 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 355248:
 --> (https://bugzilla.gnome.org/review?bug=783114&attachment=355248)

Looks good to me

::: omx/gstomxh264dec.c
@@ +123,3 @@
+  GST_OMX_INIT_STRUCT (&param);
+  param.nPortIndex = GST_OMX_VIDEO_DEC (self)->dec_in_port->index;
+

Why not do gst_pad_get_current_caps() instead? Ie, doing it from the caps
event. The result of this query will often not yield a fixed caps.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.