[Bug 784069] Add support for OMX_UseBuffer in gstomxvideodec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784069

--- Comment #8 from Guillaume Desmottes <gdesmott at gnome.org> ---
Review of attachment 355424:
 --> (https://bugzilla.gnome.org/review?bug=784069&attachment=355424)

looks good to me; some trivial comments.

::: omx/gstomxvideodec.c
@@ +2699,3 @@
+  self->use_buffers = FALSE;
+  if (gst_query_get_n_allocation_pools (query) > 0) {
+    GST_DEBUG_OBJECT (self, "Try using downstream buffer with OMX_UseBuffer");

"bufferS" ?

::: omx/gstomxvideodec.h
@@ +77,2 @@
   GstFlowReturn downstream_flow_ret;
+  gboolean use_buffers;

maybe add a comment explaining the semantic of this variable?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.