[Bug 784069] Add support for OMX_UseBuffer in gstomxvideodec
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Jul 12 17:17:13 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=784069
--- Comment #11 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Guillaume Desmottes from comment #8)
> Review of attachment 355424 [details] [review]:
>
> looks good to me; some trivial comments.
>
> ::: omx/gstomxvideodec.c
> @@ +2699,3 @@
> + self->use_buffers = FALSE;
> + if (gst_query_get_n_allocation_pools (query) > 0) {
> + GST_DEBUG_OBJECT (self, "Try using downstream buffer with
> OMX_UseBuffer");
>
> "bufferS" ?
>
> ::: omx/gstomxvideodec.h
> @@ +77,2 @@
> GstFlowReturn downstream_flow_ret;
> + gboolean use_buffers;
>
> maybe add a comment explaining the semantic of this variable?
Done, thx!
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list