[Bug 784847] omxvideodec: add dmabuf support for zynqultrascaleplus

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784847

--- Comment #7 from Guillaume Desmottes <gdesmott at gnome.org> ---
(In reply to Julien Isorce from comment #6)
> ::: omx/gstomxbufferpool.c
> @@ +395,3 @@
> +      gint fd;
> +
> +      fd = GPOINTER_TO_INT (omx_buf->omx_buf->pBuffer);
> 
> Oki, maybe just put a note about it, like: no need to use dmabuf caps
> feature because the fd is always garantie to be mappable for rw on
> zynq-uscale. 
> Since it is a generic code here maybe add the following to make it clear:
> 
> #if not ZYNQ
> if (!gst_memory_map(RW) && dmabuf_caps_feature not present in pool caps) {
>    bail out;
> }
> unmap;
> #endif
> 
> @@ +518,2 @@
>      /* If it's our own memory we have to set the sizes */
> +    if (!pool->other_pool && !pool->dmabuf) {
> 
> I do not know either, maybe the reason why it is not in
> gst_omx_memory_allocator_alloc is because it needs to be done after append.
> If no reason then yes it should be moved. Does git blame tell more about it ?

I guess in theory we could imagine the OMX component outputing smaller buffers
at some point, in which case it makes sense to do it later indeed.
It won't happen here as decoded frames have a fixed size but best to stay
generic.

I'll change my patch to update the size/offset for DMA buffers as well.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.