[Bug 754885] Re-enable passthrough mode when no longer scaling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754885

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355475|none                        |reviewed
             status|                            |

--- Comment #16 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 355475:
 --> (https://bugzilla.gnome.org/review?bug=754885&attachment=355475)

::: tests/elements/test-vaapipostproc.c
@@ +17,3 @@
+  gboolean ret;
+
+  usleep (300000);

why this sleep?

it shouldn't be better to use g_timeout_add_seconds() to call this funciton?

@@ +22,3 @@
+
+  if (ret)
+    g_print ("Now this pipeline is on passthrough mode\n");

I would use gst_println()

@@ +34,3 @@
+  static gfloat value = 1.0;
+
+  value = value == 1.0 ? 0.5 : 1.0;

uh? is this to iterate between 1 and 0.5? looks odd

@@ +35,3 @@
+
+  value = value == 1.0 ? 0.5 : 1.0;
+  g_object_set (G_OBJECT (data->postproc), "contrast", value, NULL);

it is not required to do that G_OBJECT() casting, since g_object_set accepts
gpointer, thus it does the proper casting.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.