[Bug 784012] decodebin3: Protect dbin->collection with the SELECTION_LOCK

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jul 13 14:24:14 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=784012

--- Comment #3 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 355518
  --> https://bugzilla.gnome.org/attachment.cgi?id=355518&action=edit
decodebin3: Protect fields related to streams handling with the SELECTION_LOCK

Fields related to stream handling (input_streams,
output_streams, slots, guint slot_id) where used totally unprotected
until know.

This lead to several races, especially playing back RTSP streams.

To protect those fields, the OBJECT_LOCK can not be used as we sometimes
need to be able to post message on the bus while holding it.

decodebin3 already has a lock to manage stream selection, and in the end
it makes sense to protect all the stream management fields with the same
lock which is why we reuse the SELECTION_LOCK here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list