[Bug 784908] v4l2videodec: Implement stable naming scheme for elements

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jul 13 14:40:12 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=784908

--- Comment #7 from Michael Tretter <m.tretter at pengutronix.de> ---
(In reply to Nicolas Dufresne (stormer) from comment #6)
> That's nice, I'll look at it soon, don't worry, just a little busy this
> week. Some general notes, instead of implementing subclasses, which seems
> all boiler plate, can we just add more items in the cdata ?
> 
> For the metadata
>  - longname
>  - description
> 
> The gst_v4l2_is_*_dec () are completly generic, and should not be needed
> really. Registration parameter is all covered already.

My first try was an implementation without subclasses and using the register
function to decide which type to register, because the boilerplate seemed to
much to me as well. However, in that case, having multiple elements for a
single v4l2 device (e.g., v4l2h264dec and v4l2mpegdec using the same device)
didn't work unless I would add a lot more logic to gstv4l2.c. To keep things
separate, having multiple subclasses seemed a better fit.

> Another thing, you
> are taking authorship of these element, I don't think this is fair,
> considering you are just wrapping.

I was really hesitating to claim authorship, because there is nothing that I
really added, but I didn't really know what else to do. I will happily put you
as author, if you agree.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list