[Bug 784847] omxvideodec: add dmabuf support for zynqultrascaleplus

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784847

--- Comment #13 from Guillaume Desmottes <gdesmott at gnome.org> ---
(In reply to Nicolas Dufresne (stormer) from comment #12)
> (In reply to Guillaume Desmottes from comment #9)
> > I think I fixed all your comments. The two remaining open questions are:
> > - Do we want the allocators as a soft dep or not?
> 
> The DMABuf allocator won't compile on Windows or any non-posix system
> because it uses the posix API directly (like mmap()). libgstallocators
> compile out that allocator on non-linux which forces pretty much all the
> users to out-compile it too.

>From what I see the DMA/FD allocator/memory are always built-in but the alloc
and map fd memory API will just return NULL if they don't have mmap.
So I think we should be good actually.

> So far gst-omx has only bee deployed on Linux I think, but still, we could
> at least check the OS before doing the include. In current case it's easy,
> if we have Allegro's DMABuf extension, we include it, otherwise we ifdef it
> out. One suggestion, to make it easier for other platform that would like to
> adopt Allegro proposed API, would be to keep that code under a single ifdef
> (removing the if ZINQ...).

Ok I'll do that.

> > - Should we fallback to the classic mode if DMA failed?
> 
> If we negotiate SystemMemory, we should, since classic mode is able to copy
> the frames to fix the alignment. Though, if we negotiate DMABuf caps
> feature, we can't, we'll have to error out if importation failed. Until we
> can figure-out a way to negotiate more stuff through DMABuf caps feature.
> Remains that this is embedded, were the allocation is well controlled, so I
> would not be worried either way. I would not even make it a blocker if we
> have no fallback.

Ok I'll add the fallback except if the negotiated caps as the dmabuf feature.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.