[Bug 784779] gl: public gstgl headers should not include GL headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784779

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355315|none                        |needs-work
             status|                            |

--- Comment #3 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 355315:
 --> (https://bugzilla.gnome.org/review?bug=784779&attachment=355315)

The gstglfuncs include hunk below is a blocker.

::: gst-libs/gst/gl/gstglformat.c
@@ +36,3 @@
+
+#include "gstglcontext.h"
+#include "gstglfuncs.h"

Why the change from #include <> to #include "" ?

::: gst-libs/gst/gl/gstglframebuffer.h
@@ +24,2 @@
 #include <gst/gl/gstgl_fwd.h>
+#include <gst/gl/gstglfuncs.h>

Won't this cause the GL headers to be required again?

::: gst-libs/gst/gl/gstglmemorypbo.c
@@ +31,3 @@
+#include "gstglcontext.h"
+#include "gstglfuncs.h"
+#include "gstglutils.h"

Why the change from #include <> to #include "" ?

::: tests/check/libs/gstglmemory.c
@@ +37,3 @@
+#if defined(EGLint) || defined(EGLBoolean) || defined(EGLAPI)
+#error egl headers should not be included
+#endif

If you want do this, these should be in their own separate test

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.