[Bug 784846] audioaggregator: Deadlock for specific files playback since 20bf97f08912f0edb72bfdcdde4e5c40acb29823

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784846

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355560|none                        |accepted-commit_now
             status|                            |

--- Comment #6 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 355560:
 --> (https://bugzilla.gnome.org/review?bug=784846&attachment=355560)

Looks good, my comments are just nitpick, no worries if you don't have time.

::: gst-libs/gst/audio/gstaudioaggregator.c
@@ +789,3 @@
+        !GST_BUFFER_FLAG_IS_SET (inbuf, GST_BUFFER_FLAG_GAP)) {
+      GST_WARNING_OBJECT (pad, "Dropping 0-sized buffer missing either a"
+          " duration or a GAP flag: %" GST_PTR_FORMAT, inbuf);

Nitpick, but something simpler like "Dropping non-GAP empty buffers" seems
better to me.

@@ +794,3 @@
+
+    pad->priv->size = gst_util_uint64_scale (GST_BUFFER_DURATION (inbuf),
rate,
+        GST_SECOND);

How hard would it be to rename size in something like "num_frames" or similar ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.