[Bug 784911] aggregate: chain_internal function called from two different threads for the same pad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784911

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355598|none                        |needs-work
             status|                            |

--- Comment #12 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 355598:
 --> (https://bugzilla.gnome.org/review?bug=784911&attachment=355598)

Still missing an update to the priv->flush_lock comment.

::: gst-libs/gst/base/gstaggregator.c
@@ +2488,3 @@

+/* This function can be called from the srcpad streaming thread for GAP
+ * handling. Don't get the flush lock in here */

Documentation should state:
- It's called normally from sinkpad stream threads, in which case it's called
with the FLUSH_LOCK held.
- In may also be called from the srcpad thread in the case of GAP handling,

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.